fix: specify encoding always when writing text to a file #2129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antazoey
changed the title
config.write_to_disk and specify encoding
antazoey
force-pushed
the
fix/improve-cfg-err
branch
from
9f2e2d1
to
05c6218
Compare
fubuloubu
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
config.write_to_disk()fixes: #2088
NOTE: The OZ specific issue was actually resolved via other means as both part of 0.8 and #2123 combined but the real problem is fixed by always specifying encoding if we can when calling
write_text(), so will this PR it will finally close the issue.How I did it
How to verify it
Checklist