fix: support bytes array argument in solidity and vyper contracts #2255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fubuloubu
previously approved these changes
Aug 30, 2024
Co-authored-by: El De-dog-lo <3859395+fubuloubu@users.noreply.github.com>
antazoey
previously approved these changes
Aug 30, 2024
antazoey
previously approved these changes
Aug 30, 2024
There was a problem hiding this comment.
a tuple of nits but looks good
(joke by @bitwise-constructs )
added 2 commits
September 3, 2024 11:19
added 2 commits
September 3, 2024 12:59
antazoey
previously approved these changes
Sep 3, 2024
added 2 commits
September 3, 2024 14:18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Added support for bytes array argument in solidity and vyper contracts
How I did it
Added a value converter for a list of hex values to a single concatenated hex value
How to verify it
tx = contract_instance.functionWithCalldata(["0x123456", "0xabcd"], sender=owner)
for
functionWithCalldata(bytes calldata data)
Checklist