Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mistakenly changed sources to in-memory manifest #2272

Merged
merged 7 commits into from
Sep 10, 2024

Conversation

antazoey
Copy link
Member

@antazoey antazoey commented Sep 9, 2024

What I did

fixes: #2271

To reproduce problem:

  1. Have a contract, working good, with a test.
  2. Run ape test, all is good
  3. Make a change to the contract that causes a compiler error
  4. Run ape test again, test acts like it did before, and there is no compiler error.

They key is that the change must be problematic and cause errors

How I did it

Frustratingly find spot where source Id is being overridden
Restore it.
Also, adjust error message

Test tbd

How to verify it

Checklist

  • All changes are completed
  • New test cases have been added
  • Documentation has been updated

@antazoey
Copy link
Member Author

antazoey commented Sep 9, 2024

  • Also fix bug where when you uninstall a compiler and then make changes to a change - will be a second PR
  • Get feedback from bug reporter - will come back to this
  • Add better integration test

@antazoey antazoey changed the title fix: mistakenly changed sources in in-memory manifest, causing compiler errors to get eaten fix: mistakenly changed sources to in-memory manifest Sep 9, 2024
@antazoey antazoey merged commit 203e63d into ApeWorX:main Sep 10, 2024
16 checks passed
@antazoey antazoey deleted the fix/compile-errors-ignored branch September 10, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contracts not re-compiling during ape test after changes.
3 participants