Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add windows to CI matrix #97

Closed
wants to merge 7 commits into from
Closed

chore: add windows to CI matrix #97

wants to merge 7 commits into from

Conversation

fubuloubu
Copy link
Member

What I did

Related issue: #95

@fubuloubu
Copy link
Member Author

blocked on #91

@antazoey
Copy link
Member

antazoey commented Feb 3, 2022

@fubuloubu This PR was opened in July and seems to only change a single line of code.
Can we close this and re-pick it up when we are able?

@fubuloubu
Copy link
Member Author

@fubuloubu This PR was opened in July and seems to only change a single line of code. Can we close this and re-pick it up when we are able?

I think we can just keep it around as a reminder to keep trying this every once in a while

Single line means very unlikely to have a merge conflict!

@johnson2427
Copy link
Contributor

I have no idea how I broke github so badly on this one, but wow

@johnson2427
Copy link
Contributor

pyethash hasn't been updated since 2015, and it's the crux of this issue in windows

@fubuloubu
Copy link
Member Author

No worries, this is a known issue blocking this

Something new is that @banteg wanted to explore using pysha3 backend instead, which might work for windows

@NotPeopling2day NotPeopling2day force-pushed the chore/windows-ci branch 2 times, most recently from 715bea7 to ef3ef07 Compare December 13, 2022 17:28
@NotPeopling2day NotPeopling2day force-pushed the chore/windows-ci branch 2 times, most recently from 56294b0 to fe73a00 Compare December 13, 2022 17:50
@NotPeopling2day
Copy link
Contributor

I attempted to rebase this ticket, but the scope continues to grow and additional work will be needed to integrate the geth installation process. I'm closing the ticket in favor of a backlog issue we can track on this work.

https://linear.app/apeworx/issue/APE-116/general-windows-support

@fubuloubu fubuloubu deleted the chore/windows-ci branch December 13, 2022 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants