-
-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add windows to CI matrix #97
Conversation
blocked on #91 |
91e6338
to
6ea28e8
Compare
6ea28e8
to
2d79f6e
Compare
2d79f6e
to
9482d65
Compare
73776e7
to
757d082
Compare
@fubuloubu This PR was opened in July and seems to only change a single line of code. |
I think we can just keep it around as a reminder to keep trying this every once in a while Single line means very unlikely to have a merge conflict! |
b709bc7
to
4568e34
Compare
I have no idea how I broke github so badly on this one, but wow |
pyethash hasn't been updated since 2015, and it's the crux of this issue in windows |
No worries, this is a known issue blocking this Something new is that @banteg wanted to explore using pysha3 backend instead, which might work for windows |
715bea7
to
ef3ef07
Compare
56294b0
to
fe73a00
Compare
fe73a00
to
67f06d6
Compare
I attempted to rebase this ticket, but the scope continues to grow and additional work will be needed to integrate the geth installation process. I'm closing the ticket in favor of a backlog issue we can track on this work. https://linear.app/apeworx/issue/APE-116/general-windows-support |
What I did
Related issue: #95