Bringing us up to the latest pytest (3.4.0). Introduced a pytest.ini … #3995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to manage the configuration of logging options as the logging scheme in pytest changed fairly radically between 3.2.5 and 3.3.0 and again between 3.3.0 and 3.4.0. Removed old logging config in PlosPage to make it clear where we manage log options. Also relaxed some minor style validations, font-weight, that was causing a failure in test_reactivate_ms.py. Note you MUST uninstall pytest-sugar for this change as the latest version available as of right now (0.9.0) is incompatible with pytest 3.4.0.
…ed in Base/PlosPage.py
patrickneve
previously approved these changes
Feb 8, 2018
|
Thank you, Pat. Glad to make you feel better ;-) I will point out, however, that we are sticklers, in Aperta for going through the various checks - indicated by the checkboxen in the description and checking them before signing off. Would you be so kind as to go through them? |
added 6 commits
February 13, 2018 12:13
… comparative filename that is URL encoded on the page.
…ummary text as it gets updated.
…nse of what this role is, removed long term commented code.
…tasks have different locators in diff view.
achoe-PLOS
suggested changes
Feb 16, 2018
| :return: True or False, if taskname is unknown. | ||
| """ | ||
| tasks = self._gets(self._task_headings) | ||
| time.sleep(3) |
test/frontend/Pages/paper_tracker.py
Outdated
| #assert subhead.value_of_css_property('font-size') == '18px' | ||
| #assert subhead.value_of_css_property('line-height') == '25.7167px' | ||
| #assert subhead.value_of_css_property('color') == 'rgba(51, 51, 51, 1)' | ||
| Validating Main Heading |
There was a problem hiding this comment.
It's not clear from the docstring what this method is supposed to do.
test/frontend/Pages/profile_page.py
Outdated
| # the page dialog that causes a failure. I feel dirty. | ||
| time.sleep(1) | ||
| # time.sleep(1) |
| line_height) | ||
| assert title.value_of_css_property('color') == color, \ | ||
| '{0) is not equal to {1}'.format(title.value_of_css_property('color'), color) | ||
| '{0} is not equal to {1}'.format(title.value_of_css_property('color'), color) |
test/frontend/test_cns.py
Outdated
| # Outputting the title allows us to validate update following conversion | ||
| manuscript_page.get_paper_short_doi_from_url() | ||
| title = manuscript_page.get_paper_title_from_page() | ||
| logging.info(u'Paper page title is: {0}'.format(title)) | ||
|
|
||
| def test_core_validate_pp_submission_with_review_overlay(self): | ||
| def rest_core_validate_pp_submission_with_review_overlay(self): |
|
@jgray-PLOS looks good overall; I just have a few comments. |
added 2 commits
February 16, 2018 13:31
…aned up some comments and removed debugging sleep.
|
Addressed all your comments @achoe-PLOS . Thank you for the thorough review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For reinstate manuscript test:
JIRA/TeamCity issue: https://teamcity.plos.org/teamcity/viewLog.html?buildId=148700&tab=buildResultsDiv&buildTypeId=Aperta_NoNoseIntegrationTestOnSfoCI#testNameId-2171890486949554082
What this PR does:
Bringing us up to the latest pytest (3.4.0). Introduced a pytest.ini to manage the configuration of logging options as the logging scheme in pytest changed fairly radically between 3.2.5 and 3.3.0 and again between 3.3.0 and 3.4.0. Removed old logging config in PlosPage to make it clear where we manage log options. Also relaxed some minor style validations, font-weight, that was causing a failure in test_reactivate_ms.py. Note you MUST update/upgrade pytest-sugar to v.0.9.1 for this change as the previous version (0.9.0) is incompatible with pytest 3.4.0.
Note that the scope of this PR was expanded to include a fix for an intermittent problem that is occurring for the figure task upload test. In that case we were comparing a uuencoded filename against a non-encoded filename and signalling a spurious error.
Notes
The incompatibility between pytest 3.4.0 and pytest-sugar is fixed in pytest-sugar 0.9.1. Please be sure you upgrade or sadness will ensue.
Code Review Tasks:
Reviewer tasks:
complexity of working around such use. Comment why when used.
After the Code Review:
Reviewer tasks: