Swift 5.7 support: Replace the AssociatedTypeRequirementsKit package with native casts #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 25, 2022
Swift 5.7 support: remove AssociatedTypeRequirementsKit dependency
Apodini/ApodiniTypeInformation#16
Merged
Codecov Report
@@ Coverage Diff @@
## develop #8 +/- ##
===========================================
+ Coverage 90.46% 95.19% +4.73%
===========================================
Files 23 23
Lines 503 498 -5
===========================================
+ Hits 455 474 +19
+ Misses 48 24 -24
Continue to review full report at Codecov.
|
Supereg
approved these changes
Sep 26, 2022
PSchmiedmayer
approved these changes
Sep 26, 2022
There was a problem hiding this comment.
Nice, very cool to see the usage of existentials here! Thank you @lukaskollmer! 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swift 5.7 support
♻️ Current situation & Problem
The AssociatedTypeRequirementsKit package doesn't seem to work in release builds in Swift 5.7.
💡 Proposed solution
We remove the dependency on the AssociatedTypeRequirementsKit package, and instead uses native Swift casts.
⚙️ Release Notes
➕ Additional Information
n/a
Related PRs
Testing
n/a, no functionality was changed
Reviewer Nudging
the code diff
Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: