Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the new validation attributes from .NET 8 #1142

Closed
martintmk opened this issue Apr 18, 2023 · 1 comment
Closed

Use the new validation attributes from .NET 8 #1142

martintmk opened this issue Apr 18, 2023 · 1 comment
Labels
up-for-grabs v8 Issues related to the new version 8 of the Polly library.
Milestone
v8.0.0

Comments

@martintmk
Copy link
Contributor

Once we switch to System.ComponentModel.Annotations version 8.0.0 we could use the new validation attributes (dotnet/runtime#77402) and drop some of our custom stuff:

https://github.com/App-vNext/Polly/blob/main/src/Polly.Core/Utils/TimeSpanAttribute.cs
https://github.com/App-vNext/Polly/blob/main/src/Polly.Core/Timeout/TimeoutAttribute.cs
@martintmk martintmk added the v8 Issues related to the new version 8 of the Polly library. label Apr 18, 2023
@martintmk martintmk added this to the v8.0.0 milestone Apr 18, 2023
@martintmk
Copy link
Contributor Author

No longer relevant as these internal attributes were dropped in #1351.

@github-project-automation github-project-automation bot moved this to Done in Polly v8 Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
up-for-grabs v8 Issues related to the new version 8 of the Polly library.
Projects
No open projects
Polly v8
Status: Done
Milestone
v8.0.0
Development

No branches or pull requests
1 participant
@martintmk