Drop custom validation attributes #1351
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details on the issue fix or feature implementation
Having custom internal validation attributes causes problems with the code-generator in:
dotnet/extensions#4108
However, after going through these we don't actually need them.
TimeSpanAttribute: Can be replaced with
RangeAttribute`TimeoutAttribute
: Can be replaced withRangeAttribute
, while changing the validation behavior slightly. We now enforce valid timeout value in range of 1 second to 24 hours. Defaults to 30 seconds.Confirm the following