Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

also benchmark on net7 #1009

Merged
merged 4 commits into from
Jan 9, 2023
Merged

also benchmark on net7 #1009

merged 4 commits into from
Jan 9, 2023

Conversation

SimonCropp
Copy link
Contributor

IMO benchmarks should be run against the current stable .net

@codecov-commenter
Copy link

codecov-commenter commented Jan 8, 2023

Codecov Report

Merging #1009 (b6768be) into main (6f997c4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1009   +/-   ##
=======================================
  Coverage   71.11%   71.11%           
=======================================
  Files         137      137           
  Lines        3756     3756           
  Branches      764      764           
=======================================
  Hits         2671     2671           
  Misses        874      874           
  Partials      211      211           
Flag Coverage Δ
linux 71.11% <ø> (ø)
macos 71.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@martincostello martincostello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe have the option for both TFMs as 6 is LTS, but otherwise I don't think benchmarking with 7 is an issue.

@SimonCropp
Copy link
Contributor Author

@martincostello done

Maybe have the option for both TFMs as 6 is LTS

@SimonCropp SimonCropp changed the title benchmarks on net7 also benchmark on net7 Jan 9, 2023
@SimonCropp SimonCropp merged commit 0e8a9a7 into main Jan 9, 2023
@SimonCropp SimonCropp deleted the benchmarks-on-net7 branch January 9, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants