Drop DelegatingResilienceStrategy #1063
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue or feature being addressed
When writing additional tests, I realized that the
DelegatingResilienceStrategy
doesn't work really well when you want to share theResilienceStrategy
across different pipelines. The problem is with the mutableNext
property. It also creates ambiguity when implementing a new strategy as we now have two base classes to derive from.To fix this problem and simplify the API we are dropping
DelegatingResilienceStrategy
and making it an internal implementation detail that is used when we are linking multiple strategies together.This simplifies the API surface and also removes some infra around freezing the pipelines which won't be needed anymore.
The downside is slightly slower execution; however, we should focus on clean API first.
Details on the issue fix or feature implementation
Confirm the following