Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unstable tests #1115

Merged
merged 3 commits into from
Apr 12, 2023
Merged

Fix unstable tests #1115

merged 3 commits into from
Apr 12, 2023

Conversation

martintmk
Copy link
Contributor

@martintmk martintmk commented Apr 12, 2023

Details on the issue fix or feature implementation

With the introduction of ResilienceContext pooling (#1111) the "NotInitialized" assertion in ResilienceStrategyTests is no longer reliable because other tests might get the context from the pool and initialize it. This causes test instability.

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martintmk martintmk self-assigned this Apr 12, 2023
@martintmk martintmk added the v8 Issues related to the new version 8 of the Polly library. label Apr 12, 2023
@martintmk martintmk added this to the v8.0.0 milestone Apr 12, 2023
@martintmk martintmk enabled auto-merge (squash) April 12, 2023 15:11
@codecov-commenter
Copy link

Codecov Report

Merging #1115 (c8b9480) into main (e891364) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main    #1115   +/-   ##
=======================================
  Coverage   77.78%   77.78%           
=======================================
  Files         200      200           
  Lines        4766     4766           
  Branches      851      851           
=======================================
  Hits         3707     3707           
  Misses        854      854           
  Partials      205      205           
Flag Coverage Δ
linux ?
macos 77.78% <ø> (ø)
windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@martintmk martintmk merged commit 97c2307 into main Apr 12, 2023
@martintmk martintmk deleted the mtomka/fix-unstable-tests branch April 12, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v8 Issues related to the new version 8 of the Polly library.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants