Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop TimeProvider.CancelAfter #1352

Merged
merged 3 commits into from
Jun 26, 2023
Merged

Drop TimeProvider.CancelAfter #1352

merged 3 commits into from
Jun 26, 2023

Conversation

martintmk
Copy link
Contributor

@martintmk martintmk commented Jun 26, 2023

Details on the issue fix or feature implementation

In this PR we are syncing our internal implementation of time provider with the official one. In follow-up I'll try to address the Delay.

Contributes to #1348

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martintmk martintmk added the v8 Issues related to the new version 8 of the Polly library. label Jun 26, 2023
@martintmk martintmk added this to the v8.0.0 milestone Jun 26, 2023
@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Merging #1352 (52b3b11) into main (761d969) will decrease coverage by 0.09%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1352      +/-   ##
==========================================
- Coverage   83.59%   83.51%   -0.09%     
==========================================
  Files         270      268       -2     
  Lines        6396     6362      -34     
  Branches     1008      999       -9     
==========================================
- Hits         5347     5313      -34     
  Misses        840      840              
  Partials      209      209              
Flag Coverage Δ
linux 83.51% <100.00%> (-0.09%) ⬇️
macos 83.51% <100.00%> (-0.09%) ⬇️
windows 83.51% <100.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rc/Polly.Core/Utils/CancellationTokenSourcePool.cs 100.00% <ø> (ø)
...re/Utils/CancellationTokenSourcePool.Disposable.cs 100.00% <100.00%> (ø)
...y.Core/Utils/CancellationTokenSourcePool.Pooled.cs 100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes

@martintmk martintmk merged commit 8f5dc6c into main Jun 26, 2023
@martintmk martintmk deleted the mtomka/cleanup-timeprovider branch June 26, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v8 Issues related to the new version 8 of the Polly library.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants