Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include PublicApiAnalyzers #1400

Merged
merged 7 commits into from
Jul 14, 2023
Merged

Include PublicApiAnalyzers #1400

merged 7 commits into from
Jul 14, 2023

Conversation

martintmk
Copy link
Contributor

@martintmk martintmk commented Jul 13, 2023

Details on the issue fix or feature implementation

We can include these now and just switch content from PublicAPI.Unshipped.txt to PublicAPI.Shipped.txt upon release.

Contributes to #1090

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martintmk martintmk added the v8 Issues related to the new version 8 of the Polly library. label Jul 13, 2023
@martintmk martintmk added this to the v8.0.0 milestone Jul 13, 2023
@martintmk martintmk self-assigned this Jul 13, 2023
@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Merging #1400 (1ca0d53) into main (715dbcc) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1400   +/-   ##
=======================================
  Coverage   83.80%   83.80%           
=======================================
  Files         273      273           
  Lines        6476     6476           
  Branches     1010     1010           
=======================================
  Hits         5427     5427           
  Misses        840      840           
  Partials      209      209           
Flag Coverage Δ
linux ?
macos 83.80% <100.00%> (ø)
windows 83.80% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...e/CircuitBreaker/BrokenCircuitException.TResult.cs 100.00% <ø> (ø)
...olly.Core/CircuitBreaker/BrokenCircuitException.cs 100.00% <ø> (ø)
...ly.Core/CircuitBreaker/IsolatedCircuitException.cs 100.00% <ø> (ø)
src/Polly.Core/ExecutionRejectedException.cs 100.00% <ø> (ø)
src/Polly.Core/ResilienceContext.cs 100.00% <ø> (ø)
...c/Polly.Core/ResilienceStrategy.Async.ValueTask.cs 100.00% <ø> (ø)
.../Polly.Core/ResilienceStrategy.Async.ValueTaskT.cs 100.00% <ø> (ø)
src/Polly.Core/ResilienceStrategy.Sync.cs 100.00% <ø> (ø)
src/Polly.Core/ResilienceStrategy.SyncT.cs 100.00% <ø> (ø)
src/Polly.Core/ResilienceStrategy.TResult.Async.cs 100.00% <ø> (ø)
... and 5 more

src/Polly.Core/CircuitBreaker/BrokenCircuitException.cs Outdated Show resolved Hide resolved
src/Polly.Core/ResilienceContext.cs Show resolved Hide resolved
src/Polly/Bulkhead/BulkheadRejectedException.cs Outdated Show resolved Hide resolved
src/Polly/Polly.csproj Outdated Show resolved Hide resolved
src/Polly/PublicAPI.Shipped.txt Outdated Show resolved Hide resolved
@martintmk martintmk force-pushed the mtomka/public-api-analyzers branch from e0ecf61 to 1ca0d53 Compare July 14, 2023 12:27
@martintmk martintmk enabled auto-merge (squash) July 14, 2023 12:32
@martintmk martintmk merged commit 54cff7b into main Jul 14, 2023
@martintmk martintmk deleted the mtomka/public-api-analyzers branch July 14, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v8 Issues related to the new version 8 of the Polly library.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants