Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix condition #1416

Merged
merged 1 commit into from
Jul 20, 2023
Merged

Fix condition #1416

merged 1 commit into from
Jul 20, 2023

Conversation

martincostello
Copy link
Member

Fix incorrect condition from the change made in 114b4ed which was still running incorrectly on Windows and macOS (example).

Fix incorrect condition
@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Merging #1416 (f854989) into main (9a63e4e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1416   +/-   ##
=======================================
  Coverage   83.83%   83.83%           
=======================================
  Files         274      274           
  Lines        6491     6491           
  Branches     1008     1008           
=======================================
  Hits         5442     5442           
  Misses        840      840           
  Partials      209      209           
Flag Coverage Δ
macos 83.83% <ø> (ø)
windows 83.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@martincostello martincostello marked this pull request as ready for review July 20, 2023 16:44
@martincostello martincostello merged commit 788d9db into main Jul 20, 2023
@martincostello martincostello deleted the fix-warning branch July 20, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants