Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ResilienceContextPool improvements #1493

Merged
merged 2 commits into from
Aug 16, 2023
Merged

ResilienceContextPool improvements #1493

merged 2 commits into from
Aug 16, 2023

Conversation

martintmk
Copy link
Contributor

@martintmk martintmk commented Aug 16, 2023

Details on the issue fix or feature implementation

  • This change allows us to make the ResilienceContext.ContinueOnCapturedContext property read-only.
  • Introduced ResilienceContextCreationArguments so we can add more members to it in the future without breaking changes.

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martintmk martintmk added the v8 Issues related to the new version 8 of the Polly library. label Aug 16, 2023
@martintmk martintmk added this to the v8.0.0 milestone Aug 16, 2023
@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #1493 (7b3b9d6) into main (e5622c0) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1493      +/-   ##
==========================================
+ Coverage   83.61%   83.64%   +0.02%     
==========================================
  Files         267      268       +1     
  Lines        6385     6394       +9     
  Branches     1007     1007              
==========================================
+ Hits         5339     5348       +9     
  Misses        837      837              
  Partials      209      209              
Flag Coverage Δ
linux 83.64% <100.00%> (+0.02%) ⬆️
macos 83.64% <100.00%> (+0.02%) ⬆️
windows 83.64% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/Polly.Core/ResilienceContext.cs 100.00% <100.00%> (ø)
...c/Polly.Core/ResilienceContextCreationArguments.cs 100.00% <100.00%> (ø)
src/Polly.Core/ResilienceContextPool.Shared.cs 100.00% <100.00%> (ø)
src/Polly.Core/ResilienceContextPool.cs 100.00% <100.00%> (ø)
...lly/Utilities/Wrappers/ResilienceContextFactory.cs 100.00% <100.00%> (ø)

Copy link
Member

@martincostello martincostello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be interesting to see if this has any effect on the benchmark results.

@martintmk martintmk merged commit 1358076 into main Aug 16, 2023
@martintmk martintmk deleted the mtomka/pool-improvements branch August 16, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v8 Issues related to the new version 8 of the Polly library.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants