Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup samples #1544

Merged
merged 2 commits into from
Sep 4, 2023
Merged

Cleanup samples #1544

merged 2 commits into from
Sep 4, 2023

Conversation

martintmk
Copy link
Contributor

@martintmk martintmk commented Sep 4, 2023

Details on the issue fix or feature implementation

  • Using the same rules for src folder
  • Suppressing some rules that will make samples less readable

Contributes to #1540

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martintmk martintmk added the v8 Issues related to the new version 8 of the Polly library. label Sep 4, 2023
@martintmk martintmk added this to the v8.0.0 milestone Sep 4, 2023
@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (9ef832c) 83.92% compared to head (18a1685) 83.92%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1544   +/-   ##
=======================================
  Coverage   83.92%   83.92%           
=======================================
  Files         279      279           
  Lines        6518     6518           
  Branches     1017     1017           
=======================================
  Hits         5470     5470           
  Misses        839      839           
  Partials      209      209           
Flag Coverage Δ
linux 83.92% <ø> (?)
macos ?
windows 83.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martintmk martintmk enabled auto-merge (squash) September 4, 2023 10:18
@martintmk martintmk merged commit da9db1b into main Sep 4, 2023
@martintmk martintmk deleted the mtomka/cleanup-samples branch September 4, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v8 Issues related to the new version 8 of the Polly library.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants