Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delay pipeline disposal when still in use #1579

Merged
merged 8 commits into from
Sep 8, 2023

Conversation

martintmk
Copy link
Contributor

@martintmk martintmk commented Sep 8, 2023

Details on the issue fix or feature implementation

When pipeline is created using the registry the disposal will be delayed until the pipeline is no longer in use. The pipeline must be freed within 30 seconds otherwise the disposal is forced.

Closes #1578

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martintmk martintmk added the v8 Issues related to the new version 8 of the Polly library. label Sep 8, 2023
@martintmk martintmk added this to the v8.0.0 milestone Sep 8, 2023
@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.05% 🎉

Comparison is base (6999e7c) 83.93% compared to head (984724f) 83.99%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1579      +/-   ##
==========================================
+ Coverage   83.93%   83.99%   +0.05%     
==========================================
  Files         279      280       +1     
  Lines        6525     6548      +23     
  Branches     1019     1020       +1     
==========================================
+ Hits         5477     5500      +23     
  Misses        839      839              
  Partials      209      209              
Flag Coverage Δ
linux 83.99% <100.00%> (+0.05%) ⬆️
macos 83.99% <100.00%> (+0.05%) ⬆️
windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
....Core/Registry/RegistryPipelineComponentBuilder.cs 100.00% <100.00%> (ø)
....Core/Utils/Pipeline/ExecutionTrackingComponent.cs 100.00% <100.00%> (ø)
...ly.Core/Utils/Pipeline/PipelineComponentFactory.cs 100.00% <100.00%> (ø)
src/Polly.Testing/ResiliencePipelineExtensions.cs 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.

@martintmk martintmk enabled auto-merge (squash) September 8, 2023 13:17
@martintmk martintmk merged commit a0e7735 into main Sep 8, 2023
17 checks passed
@martintmk martintmk deleted the mtomka/fix-pipeline-disposal-when-in-use branch September 8, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix v8 Issues related to the new version 8 of the Polly library.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

ObjectDisposedException thrown if a request is inflight when configuration is reloaded
2 participants