Update docs source #1641
Merged
Update docs source #1641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename exception variable.
martincostello
added
documentation
v8
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1641 +/- ##
=======================================
Coverage 84.63% 84.63%
=======================================
Files 306 306
Lines 6819 6819
Branches 1045 1045
=======================================
Hits 5771 5771
Misses 839 839
Partials 209 209
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
martintmk
reviewed
Sep 27, 2023
src/Snippets/Docs/Fallback.cs
Outdated
| @@ -125,9 +125,9 @@ public static async ValueTask<HttpResponseMessage> Action() | |||
| return Outcome.FromResult(result); | |||
| }, context, "state"); | |||
|
|
|||
| if (outcome.Exception is HttpRequestException hre) | |||
| if (outcome.Exception is HttpRequestException httpEx) | |||
There was a problem hiding this comment.
Suggested change
| if (outcome.Exception is HttpRequestException httpEx) | |
| if (outcome.Exception is HttpRequestException requestException) |
?
Change to `requestException` per feedback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename exception variable.
See #1640 (comment).