Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add banned API analyzers and fix time zone issue #1651

Merged
merged 4 commits into from
Sep 28, 2023

Conversation

martincostello
Copy link
Member

  • Add Microsoft.CodeAnalysis.BannedApiAnalyzers to detect usage of problematic code patterns.
  • Cherry-pick fix from Fix issue I was experiencing in my time zone #1650.
  • Fix StyleCop warning by updating constructor documentation (found while testing the analyzers).

martincostello and others added 3 commits September 27, 2023 21:41
Add  to detect usage of problematic code patterns.
Fix StyleCop warning by updating constructor documentation.
Add this PR to the changelog.
@martincostello martincostello marked this pull request as ready for review September 27, 2023 20:50
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (cf84069) 84.63% compared to head (fd2f2ef) 84.63%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1651   +/-   ##
=======================================
  Coverage   84.63%   84.63%           
=======================================
  Files         306      306           
  Lines        6819     6819           
  Branches     1045     1045           
=======================================
  Hits         5771     5771           
  Misses        839      839           
  Partials      209      209           
Flag Coverage Δ
linux 84.63% <100.00%> (ø)
macos 84.63% <100.00%> (ø)
windows 84.63% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ircuitBreaker/Controller/CircuitStateController.cs 100.00% <100.00%> (ø)
.../Polly/RateLimit/LockFreeTokenBucketRateLimiter.cs 82.75% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martincostello martincostello merged commit 49dea3c into App-vNext:main Sep 28, 2023
18 checks passed
@martincostello martincostello deleted the banned-api-analyzers branch September 28, 2023 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants