Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simmy v8 feedback #1682

Merged
merged 8 commits into from
Oct 22, 2023
Merged

Simmy v8 feedback #1682

merged 8 commits into from
Oct 22, 2023

Conversation

vany0114
Copy link
Contributor

@vany0114 vany0114 commented Oct 9, 2023

Pull Request

Address the remaining feedback in the initial implementation and also the feedback on the Simmy API (#1571).

Details on the issue fix or feature implementation

  • Splits fault strategy from outcomes strategy
  • Removes Outcome property from options and relies only on OutcomeGenerator to avoid issues with disposable outcomes
  • Removes enabled parameter from all convenience extensions

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@vany0114 vany0114 changed the title Simmy v8 feddback Simmy v8 feedback Oct 9, 2023
@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (86b4e29) 84.65% compared to head (c151b47) 84.56%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1682      +/-   ##
==========================================
- Coverage   84.65%   84.56%   -0.10%     
==========================================
  Files         306      307       +1     
  Lines        6831     6790      -41     
  Branches     1047     1043       -4     
==========================================
- Hits         5783     5742      -41     
  Misses        839      839              
  Partials      209      209              
Flag Coverage Δ
linux 84.56% <100.00%> (-0.10%) ⬇️
macos 84.56% <100.00%> (-0.10%) ⬇️
windows 84.56% <100.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...immy/Behavior/BehaviorPipelineBuilderExtensions.cs 100.00% <100.00%> (ø)
src/Polly.Core/Simmy/Fault/FaultChaosStrategy.cs 100.00% <100.00%> (ø)
.../Polly.Core/Simmy/Fault/FaultGeneratorArguments.cs 100.00% <ø> (ø)
...Core/Simmy/Fault/FaultPipelineBuilderExtensions.cs 100.00% <100.00%> (ø)
src/Polly.Core/Simmy/Fault/FaultStrategyOptions.cs 100.00% <ø> (ø)
...Polly.Core/Simmy/Fault/OnFaultInjectedArguments.cs 100.00% <ø> (ø)
.../Simmy/Latency/LatencyPipelineBuilderExtensions.cs 100.00% <100.00%> (ø)
.../Polly.Core/Simmy/Outcomes/OutcomeChaosStrategy.cs 100.00% <100.00%> (ø)
...Simmy/Outcomes/OutcomePipelineBuilderExtensions.cs 100.00% <100.00%> (ø)
...e/Simmy/Outcomes/OutcomeStrategyOptions.TResult.cs 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

# Conflicts:
#	src/Polly.Core/Simmy/Outcomes/OutcomePipelineBuilderExtensions.TResult.cs
#	test/Polly.Core.Tests/Simmy/Outcomes/OutcomeChaosPipelineBuilderExtensionsTests.cs
@martintmk martintmk merged commit 54da87d into App-vNext:main Oct 22, 2023
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants