-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simmy v8 feedback #1682
Merged
Merged
Simmy v8 feedback #1682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ator to avoid issues with disposable outcomes
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1682 +/- ##
==========================================
- Coverage 84.65% 84.56% -0.10%
==========================================
Files 306 307 +1
Lines 6831 6790 -41
Branches 1047 1043 -4
==========================================
- Hits 5783 5742 -41
Misses 839 839
Partials 209 209
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
martintmk
reviewed
Oct 9, 2023
martintmk
reviewed
Oct 9, 2023
src/Polly.Core/Simmy/Outcomes/OutcomePipelineBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
# Conflicts: # src/Polly.Core/Simmy/Outcomes/OutcomePipelineBuilderExtensions.TResult.cs # test/Polly.Core.Tests/Simmy/Outcomes/OutcomeChaosPipelineBuilderExtensionsTests.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Address the remaining feedback in the initial implementation and also the feedback on the Simmy API (#1571).
Details on the issue fix or feature implementation
Outcome
property from options and relies only onOutcomeGenerator
to avoid issues with disposable outcomesConfirm the following