Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn off var preferences #1700

Merged

Conversation

cmeyertons
Copy link
Contributor

@cmeyertons cmeyertons commented Oct 16, 2023

Pull Request

The issue or feature being addressed

Contributors leverage code cleanup add superfluous changes to files when executing code clean up due to var preferences

Link to PR & comment: #1693 (comment)

Details on the issue fix or feature implementation

Running code cleanup on Polly.Core results for the following editorconfig scenarios results in:

  1. no changes: 15 files
  2. toggle built-in to false: 16 files
  3. turn off suggestions / cleanup for this rule: 6 files (cleaning up unnecessary usings)

After looking through the changes for options 1 & 2, it appears we are intentionally adding explicit context that is valuable in scenarios on both sides. This PR implements option 3 as the codebase does a pretty good job of being consistent while allowing for a few one-off exceptions in places where context is important.

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@cmeyertons cmeyertons force-pushed the feature/editor-config-var-preferences branch from c91a5a3 to cf19037 Compare October 16, 2023 15:10
@martincostello martincostello enabled auto-merge (squash) October 16, 2023 16:07
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (16d5fa1) 84.63% compared to head (dbb6a20) 84.63%.
Report is 14 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1700   +/-   ##
=======================================
  Coverage   84.63%   84.63%           
=======================================
  Files         306      306           
  Lines        6819     6819           
  Branches     1045     1045           
=======================================
  Hits         5771     5771           
  Misses        839      839           
  Partials      209      209           
Flag Coverage Δ
linux 84.63% <ø> (?)
macos 84.63% <ø> (ø)
windows 84.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...rc/Polly.Core/Hedging/HedgingResilienceStrategy.cs 100.00% <ø> (ø)
.../Polly.Core/Registry/ResiliencePipelineRegistry.cs 100.00% <ø> (ø)
src/Polly.Core/Retry/RetryHelper.cs 100.00% <ø> (ø)
src/Polly.Core/Utils/Pipeline/ExternalComponent.cs 100.00% <ø> (ø)
...ly.Core/Utils/Pipeline/PipelineComponentFactory.cs 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martincostello martincostello merged commit e869fe8 into App-vNext:main Oct 16, 2023
18 checks passed
@cmeyertons cmeyertons deleted the feature/editor-config-var-preferences branch October 16, 2023 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants