Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix code-ql issues #1708

Merged
merged 3 commits into from
Oct 19, 2023
Merged

Attempt to fix code-ql issues #1708

merged 3 commits into from
Oct 19, 2023

Conversation

martintmk
Copy link
Contributor

The issue or feature being addressed

#980

Details on the issue fix or feature implementation

Try to stabilize code-ql build by ignoring our analyzers.

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

Copy link
Member

@martincostello martincostello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it works 👍

eng/Analyzers.targets Outdated Show resolved Hide resolved
eng/Analyzers.targets Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (d9fe9c9) 84.65% compared to head (029cbaf) 84.65%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1708   +/-   ##
=======================================
  Coverage   84.65%   84.65%           
=======================================
  Files         306      306           
  Lines        6831     6831           
  Branches     1047     1047           
=======================================
  Hits         5783     5783           
  Misses        839      839           
  Partials      209      209           
Flag Coverage Δ
linux ?
macos 84.65% <ø> (ø)
windows 84.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martintmk
Copy link
Contributor Author

If it works 👍

WORKS! :)

@martintmk martintmk enabled auto-merge (squash) October 19, 2023 14:43
@martintmk martintmk merged commit 160efa5 into main Oct 19, 2023
14 checks passed
@martintmk martintmk deleted the mtomka/fix-code-ql-issues branch October 19, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants