Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Minor cleanups #1768

Merged
merged 7 commits into from
Nov 2, 2023
Merged

Conversation

peter-csala
Copy link
Contributor

Pull Request

Details on the issue fix or feature implementation

  • Replaced [!IMPORTANT] to [!TIP] in the migration guide
  • Removed numbering from the patterns, anti-patterns

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c5d268d) 84.53% compared to head (3c99f2a) 84.53%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1768   +/-   ##
=======================================
  Coverage   84.53%   84.53%           
=======================================
  Files         307      307           
  Lines        6777     6777           
  Branches     1043     1043           
=======================================
  Hits         5729     5729           
  Misses        839      839           
  Partials      209      209           
Flag Coverage Δ
linux 84.53% <ø> (?)
macos 84.53% <ø> (?)
windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martincostello martincostello enabled auto-merge (squash) November 2, 2023 15:37
@martintmk martintmk disabled auto-merge November 2, 2023 15:38
@martintmk
Copy link
Contributor

I made an typo in timeout.md file:

can you change ![IMPORTANT] to [!IMPORTANT] too?

@martintmk martintmk enabled auto-merge (squash) November 2, 2023 15:48
auto-merge was automatically disabled November 2, 2023 16:16

Head branch was pushed to by a user without write access

@martincostello martincostello merged commit 2384117 into App-vNext:main Nov 2, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants