Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish AoT for test on macOS #1800

Merged
merged 2 commits into from
Nov 17, 2023
Merged

Publish AoT for test on macOS #1800

merged 2 commits into from
Nov 17, 2023

Conversation

martincostello
Copy link
Member

This should work in .NET 8, so simplify by removing the condition.

This should work in .NET 8, so simplify by removing the condition.
@martincostello martincostello added this to the v8.3.0 milestone Nov 15, 2023
@martincostello martincostello enabled auto-merge (rebase) November 15, 2023 17:46
Copy link

codecov bot commented Nov 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2697912) 84.59% compared to head (8b65107) 84.59%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1800   +/-   ##
=======================================
  Coverage   84.59%   84.59%           
=======================================
  Files         308      308           
  Lines        6802     6802           
  Branches     1049     1049           
=======================================
  Hits         5754     5754           
  Misses        839      839           
  Partials      209      209           
Flag Coverage Δ
linux 84.59% <ø> (ø)
macos ?
windows 84.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martincostello
Copy link
Member Author

Something foul is afoot...

@martincostello
Copy link
Member Author

Logged dotnet/sdk#36960.

@martincostello martincostello removed this from the v8.3.0 milestone Nov 16, 2023
Target net8.0.
@martincostello martincostello enabled auto-merge (squash) November 17, 2023 00:42
@martincostello martincostello merged commit 8ded09c into main Nov 17, 2023
17 checks passed
@martincostello martincostello deleted the macos-aot branch November 17, 2023 07:56
martincostello added a commit that referenced this pull request Jan 4, 2024
- Publish AoT on macOS.
- Target net8.0 for AoT test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant