-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CA1000/S4023/S3442/S107/SA1402/SA1649 warnings #2089
Conversation
Fix S3253& S6605
Fix S103
Fix SA1625
Fix S4023
Fix CA1000
* Fix SA1402 * Update .editorconfig * Update .editorconfig
* Fix S3442 * Fix linting error
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2089 +/- ##
=======================================
Coverage 83.72% 83.72%
=======================================
Files 312 312
Lines 7126 7126
Branches 1054 1054
=======================================
Hits 5966 5966
Misses 789 789
Partials 371 371
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Your PR has conflicts that need resolving. Before starting a PR, ensure your fork is up to date and create a branch (don't work off |
@martincostello could you clarify what conflicts are we talking about? Merge conflicts? If so I don't see them on this PR And my fork is up to the date |
Pull Request
The issue or feature being addressed
#1290
max
param count to 12eng/analyzers
configs to solution file inSolution Items
Details on the issue fix or feature implementation
Confirm the following