Handle rate-limit edge case #911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a large numberOfExecutions value (e.g. int.MaxValue) is used with a small perTimeSpan value, the division between the two will create a number too small to be represented by a tick, ending up with a TimeSpan.Zero value. This then created a confusing exception message saying that the user had specified TimeSpan.Zero, when they hadn't. Improved the exception message by throwing a specific exception if onePer ends up with a zero or negative value once computed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue or feature being addressed
If a large
numberOfExecutionsvalue (e.g.int.MaxValue) is used with a smallperTimeSpanvalue, the division between the two will create a number too small to be represented by a tick, ending up with aTimeSpan.Zerovalue.This then created a confusing exception message saying that the user had specified
TimeSpan.Zero, when they hadn't.Found while creating a "big enough" rate limit to use for the benchmarks in #910.
Details on the issue fix or feature implementation
Improved the exception message by throwing a specific exception if
onePerends up with a zero or negative value once computed.Confirm the following