Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: undo failed in a nested list in a special case #503

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

LucasXu0
Copy link
Collaborator

@LucasXu0 LucasXu0 commented Sep 25, 2023

before

before_.mov

after

after_.mov

thanks @r3velated for providing the reproduction steps.

@LucasXu0 LucasXu0 force-pushed the fix_undo_fail_in_nested_list branch 2 times, most recently from 8856491 to 8ff2e7b Compare September 25, 2023 14:42
@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (7743620) 80.58% compared to head (3fe68da) 80.53%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #503      +/-   ##
==========================================
- Coverage   80.58%   80.53%   -0.05%     
==========================================
  Files         280      280              
  Lines       11773    11786      +13     
==========================================
+ Hits         9487     9492       +5     
- Misses       2286     2294       +8     
Files Coverage Δ
lib/src/editor_state.dart 86.36% <50.00%> (-0.42%) ⬇️
lib/src/core/document/node.dart 75.16% <36.36%> (-3.10%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LucasXu0 LucasXu0 marked this pull request as draft September 25, 2023 14:59
@LucasXu0 LucasXu0 force-pushed the fix_undo_fail_in_nested_list branch from 8ff2e7b to 3fe68da Compare September 26, 2023 02:38
@LucasXu0 LucasXu0 marked this pull request as ready for review September 26, 2023 02:43
@LucasXu0 LucasXu0 merged commit c5ea228 into AppFlowy-IO:main Sep 26, 2023
8 of 10 checks passed
q200892907 added a commit to q200892907/appflowy-editor that referenced this pull request Sep 27, 2023
* main: (39 commits)
  feat: support RTL in toolbar (AppFlowy-IO#496)
  fix: unable to update selection sometimes when the editor lost focus (AppFlowy-IO#509)
  fix: delete the divider on mobile will raise an error (AppFlowy-IO#508)
  fix: the cursor will flicker one frame to its previous position (AppFlowy-IO#506)
  fix: undo failed in a nested list in a special case (AppFlowy-IO#503)
  chore: bump version 1.4.3 (AppFlowy-IO#502)
  fix: image block rect overflow
  fix: the text within the <mark> tag didn't parse correctly when pasting HTML.
  chore: bump version 1.4.2
  fix: command shortcuts on the web platform should also respect the operating system
  fix: focus will lost when typing slash
  fix: unable to input text on web platform
  fix: unable to change RTL of heading (AppFlowy-IO#495)
  fix: fix mobile selection drag (AppFlowy-IO#490)
  chore: bump version 1.4.1
  fix: the placeholder doesn't appear on desktop platform
  fix: required named parameter 'onLiveTextInput' must be provided
  feat: add support for font family and font size attributes in rich text (AppFlowy-IO#486)
  fix: the color of text and highlight icon should be white (AppFlowy-IO#485)
  chore: bump version 1.4.0 (AppFlowy-IO#484)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant