Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed menu closing on some devices #941

Merged
merged 2 commits into from
Dec 11, 2024
Merged

Conversation

g-apparence
Copy link
Contributor

On mobile (android) when some users open keyboard it is automatically closing.

@CLAassistant
Copy link

CLAassistant commented Oct 24, 2024

CLA assistant check
All committers have signed the CLA.

@LucasXu0
Copy link
Collaborator

@g-apparence Please use dart fix --apply to format the code.

@LucasXu0
Copy link
Collaborator

Hi, @g-apparence. I formatted the code.

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 72.19%. Comparing base (e7d9560) to head (5193b72).
Report is 26 commits behind head on main.

Files with missing lines Patch % Lines
...b/src/editor/toolbar/mobile/mobile_toolbar_v2.dart 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #941      +/-   ##
==========================================
+ Coverage   72.07%   72.19%   +0.11%     
==========================================
  Files         318      318              
  Lines       15074    15171      +97     
==========================================
+ Hits        10864    10952      +88     
- Misses       4210     4219       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LucasXu0 LucasXu0 merged commit e6971c2 into AppFlowy-IO:main Dec 11, 2024
5 of 7 checks passed
@g-apparence
Copy link
Contributor Author

@LucasXu0 thank you,
Sorry I completely forgot to do it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants