Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add partialSliced to support partial sliced attributes #989

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

LucasXu0
Copy link
Collaborator

@LucasXu0 LucasXu0 commented Dec 12, 2024

Add the partialSliced value to indicate whether the key should be sliced if the index is out of the attribute's range.

For example, if you only need to slice the attributes when the index is within the attribute's range, add the key to partialSliced.

**Hello World** <- If you input here, it should not follow the previous format if the partialSliced value contains the AppFlowyRichTextKeys.bold

@LucasXu0 LucasXu0 force-pushed the support_link_format branch from 08b8c77 to c6e6da7 Compare December 12, 2024 06:28
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Project coverage is 72.15%. Comparing base (954ffa5) to head (c6e6da7).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
lib/src/core/document/text_delta.dart 50.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #989      +/-   ##
==========================================
- Coverage   72.15%   72.15%   -0.01%     
==========================================
  Files         319      319              
  Lines       15221    15224       +3     
==========================================
+ Hits        10983    10985       +2     
- Misses       4238     4239       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LucasXu0 LucasXu0 changed the title feat: support link format feat: add partialSliced to support partial sliced attributes Dec 12, 2024
@LucasXu0 LucasXu0 changed the title feat: add partialSliced to support partial sliced attributes feat: add partialSliced to support partial sliced attributes Dec 12, 2024
@LucasXu0 LucasXu0 merged commit ea1bcd3 into AppFlowy-IO:main Dec 12, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant