-
-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setting environmental variable ARGV0 cause some packed software malfunctioning #852
Comments
This was the relevant discussion leading to the implementation of this feature: It seems like we have a name clash of the variable here. Possibly we should change to another name for the variable. Before we change it, we should find out who is using it, and send them a depreciation notice. |
I don't think we should change our variable. People rely on it, and we documented it. Isn't it part of the specification already...? I think it's easier for neovim to change their variable name. |
Is it Neovim or zsh which would have to change? The former may be not so easy... |
@probonopd I just thought, neovim or whatever payload application has problems with |
True. But if I am not mistaken, all AppImages launched by zsh have this issue, effectively making all AppImages unusable on zsh. Correct @ngkz? |
@probonopd No, this issue only occurs if the payload calls zsh, not when zsh calls the payload. |
So, unsetting it in AppRun would work fine... |
Thanks for the clarification @ngkz - in this case a custom |
Hi @ngkz, did the comments above help you solving the issue? |
We agreed on |
AppImage sets $ARGV0 which breaks zsh. Hack around this in our appimage. fixes #9341 ref AppImage/AppImageKit#852 [ci skip]
@probonopd @TheAssassin We've updated the Neovim appimage to work around this issue. For future reference, what other environment variables is AppImage setting ? Searching the docs for ARGV0 yields nothing: https://docs.appimage.org/search.html?q=argv0&check_keywords=yes&area=default Also do not see an "environment" page on the wiki. |
Please see https://discourse.appimage.org/t/call-alternative-binary-from-appimage/93/10. |
Sure! PRs welcome for https://github.com/AppImage/docs.appimage.org. The environment variables should have been documented already, actually, but it seems they're missing. |
I added an explanation about |
@erw7 as mentioned (#852 (comment)), https://github.com/AppImage/docs.appimage.org. |
@probonopd could you give me some guidance on how to do this? I'm having this same issue with my tmux-appimage. I appreciate your help. |
Inside your AppDir, delete the
I have tested it and it works. |
causes issues with other applications. AppImage/AppImageKit#852
The runtime sets $ARGV0 which is used by zsh as argv[0] of external commands.
Because of this, when packed software calls external software which changes behavior by argv[0] via zsh, it malfunctions.
Example:
The text was updated successfully, but these errors were encountered: