Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rework: Refactor candidates #283

Merged
merged 6 commits into from
Feb 27, 2024
Merged

rework: Refactor candidates #283

merged 6 commits into from
Feb 27, 2024

Conversation

d-beezee
Copy link
Member

No description provided.

Copy link

github-actions bot commented Feb 26, 2024

Tests difference:

New Tests

< Check NotFound middleware - should return 404 and a not found err
< GET /campaigns/:campaignId/candidates  - Should filter by tryber-ids excluding values
< GET /campaigns/:campaignId/candidates  - Should filter by tryber-ids excluding values with T-char
< GET /campaigns/:campaignId/candidates  - Should filter by tryber-ids including and excluding values
< GET /campaigns/:campaignId/candidates  - Should filter by tryber-ids including and excluding values with T-char
< GET /campaigns/:campaignId/candidates  - Should filter by tryber-ids including values
< GET /campaigns/:campaignId/candidates  - Should filter by tryber-ids including values with T-char
< Get Example middleware - Should return false if path does not exists
< Get Example middleware - Should return false if path does not have method
< Get Example middleware - Should return false if path method does not have response
< Get Example middleware - Should return false if path method does not have response with requested status
< Get Example middleware - Should return false if path method response does not have application/json content
< Get Example middleware - Should return false if path method response does not have content
< Get Example middleware - Should return first example if no specific example is requested
< Get Example middleware - Should return requested example if a specific example is requested
< Get Example middleware - should return a middleware
< Not Implemented - should return a not implemented error

Removed Tests

> GET /campaigns/:campaignId/candidates  - Should filter by os excluding values
> GET /campaigns/:campaignId/candidates  - Should filter by os including and excluding values
> GET /campaigns/:campaignId/candidates  - should order by level id

@coveralls
Copy link
Collaborator

coveralls commented Feb 27, 2024

Coverage Status

coverage: 77.217% (+0.2%) from 77.028%
when pulling ecf4682 on refactor-candidates
into 9fec62e on develop.

@d-beezee d-beezee merged commit f23fcd5 into develop Feb 27, 2024
6 checks passed
@sinatragianpaolo sinatragianpaolo deleted the refactor-candidates branch March 5, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants