Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove versions from ux endpoints #349

Merged
merged 10 commits into from
Aug 14, 2024
Merged

remove versions from ux endpoints #349

merged 10 commits into from
Aug 14, 2024

Conversation

sinatragianpaolo
Copy link
Contributor

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 9, 2024 •
edited
Loading

Tests difference:

New Tests

< PATCH /campaigns/{campaignId}/ux - sentiments - Should update sentiments

Removed Tests

> GET /campaigns/{campaignId}/ux - Should return 200 if logged as admin user
> PATCH /campaigns/{campaignId}/ux - if no data insert ux data - Should insert data as version 1
> PATCH /campaigns/{campaignId}/ux - sentiments - Should add sentiments

@sinatragianpaolo sinatragianpaolo changed the base branch from turnoff-cc-verioning to develop August 9, 2024 13:51
@cannarocks cannarocks marked this pull request as ready for review August 9, 2024 14:31
@coveralls
Copy link
Collaborator

Coverage Status

coverage: 77.647% (-0.07%) from 77.718%
when pulling 95e0640 on remove-versioning-columns
into 099470a on develop.

cannarocks
cannarocks approved these changes Aug 9, 2024
View reviewed changes
Copy link
Member

@cannarocks cannarocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OneDoesNotSimplyVcsGIF

@cannarocks cannarocks merged commit 2e6ad8d into develop Aug 14, 2024
4 of 6 checks passed
@cannarocks cannarocks deleted the remove-versioning-columns branch August 14, 2024 10:54
@sinatragianpaolo sinatragianpaolo mentioned this pull request Sep 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cannarocks cannarocks cannarocks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sinatragianpaolo @coveralls @cannarocks