Sentiment chart #265
Merged
Sentiment chart #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
marcbon
commented
Sep 1, 2023
marcbon
commented
… string or number 🐛 fix(_data.ts): add custom_data property to data object 🐛 fix(_types.ts): make y property in LineData optional 🐛 fix(index.stories.tsx): change width of tooltip divs 🐛 fix(index.tsx): remove unused imports and components ✨ feat(index.tsx): add support for isScrollable prop in LineChart component
✨ feat(line/index.tsx): add curve="monotoneX" prop to Line component ✨ feat(line/index.tsx): add markers to Line component
🐛 fix(line/index.stories.tsx): remove axisBottomLabel prop from LineChart component
…function from 'http' module
🐛 fix(globalStyle.ts): fix typo in ::-webkit-scrollbar height property
🐛 fix(_types.ts): change LineData type to be an object instead of an array 🐛 fix(index.stories.tsx): update component name and add missing imports ✨ feat(index.stories.tsx): add title and description to LineChart component ✨ feat(index.stories.tsx): add custom tooltip functionality to LineChart component ✨ feat(index.stories.tsx): add scrollable LineChart component 🐛 fix(line/index.tsx): import SliceTooltipProps from @nivo/line ✨ feat(line/index.tsx): add support for interactive tooltips using SliceTooltipProps 🔧 chore(line/index.tsx): remove unused axisLeftLabel and axisBottomLabel props 🎨 style(line/index.tsx): update styling for ScrollingContainer component 🔧 chore(line/index.tsx): remove useMesh prop from ResponsiveLine component ✨ feat(line/index.tsx): enable interactivity and slices in ResponsiveLine component
…iment" 🐛 fix(line/index.tsx): fix enableSlices value from "y" to "x"
🔥 refactor(line/index.tsx): remove unused import of MD from typography/typescale 🔥 refactor(line/index.tsx): remove unused import of Tooltip from tooltip 🔥 refactor(line/index.tsx): remove unused code for Point component
✨ feat(_types.ts): remove isScrollable prop from LineChartProps interface ✨ feat(index.stories.tsx): remove unused imports and update styles in Template component ✨ feat(index.stories.tsx): update Scrollable story to use Template component 🐛 fix(index.tsx): update tooltip prop in LineChart component
🗑️ remove(line/assets/sentiment_0.svg): remove unused SVG file 🎨 style(sentiment_1.svg): update fill color of sentiment icon to #E9979B 🎨 style(sentiment_2.svg): update fill color for sentiment icon 🎨 chore(sentiment_3.svg): update fill color to #FFD7A4 🎨 chore(sentiment_4.svg): update fill color to #B3E8D9 🆕 feat(sentiment_5.svg): add new SVG file for sentiment value 5 🔧 chore(index.stories.tsx): update line chart component to include new sentiment SVG 🔨 refactor(line/index.tsx): remove unused sentiment_0.svg import ✨ feat(line/index.tsx): add support for sentiment_5.svg 🔨 refactor(line/index.tsx): change LineContainer to extend ChartContainer 🔨 refactor(line/index.tsx): remove width and height props from LineContainer 🔨 refactor(line/index.tsx): remove style prop from LineContainer 🔨 refactor(line/index.tsx): remove unused imports 🔨 refactor(line/index.tsx): reformat code for better readability 🔨 refactor(line/index.tsx): reorganize props for ResponsiveLine component 🔨 refactor(line/index.tsx): reorganize markers array 🔨 refactor(line/index.tsx): remove unused props from ResponsiveLine component
✨ feat(line/index.stories.tsx): rename LineChart to SentimentChart and update imports and types 🐛 fix(line/index.tsx): rename LineChart to SentimentChart and update imports and types
🐛 fix(line): use theme palette grey[600] for colors in index.tsx
|
Ci sono 77 componenti nel tuo branch e 76 componenti nel branch target, ma nessuna modifica nell'index.tsx. 🤷♂️ |
cannarocks
reviewed
Sep 1, 2023
cannarocks
reviewed
Sep 1, 2023
|
|
||
| const DEFAULT_CHART_MARGINS = { top: 0, right: 0, bottom: 30, left: 30 }; | ||
|
|
||
| const formatSentiment = (value: DatumValue) => { |
There was a problem hiding this comment.
questo formatSentiment come gestisce le traduzioni?conviene aggiungere il parametro i18n
There was a problem hiding this comment.
giusto, va anche messa la traduzione per "Neutral" la linea mediana
There was a problem hiding this comment.
in realtà le label per i sentiment non sono più usate in seguito alle modifiche sul design del componente, ma manterrei comunque la funzione per tutti i valori dei sentiment anche se attualmente è usato solo "neutral"
…types in SentimentChartProps
…t, and margin props to SentimentChart component ✨ feat(index.stories.tsx): add support for custom tooltip in SentimentChart component
…ctNode in data field
✨ feat(_types.ts): add i18n property to SentimentChartProps interface
✨ feat(sentiment/index.tsx): add i18n prop to formatPoint function ✨ feat(sentiment/index.tsx): add i18n prop to tooltip function
…function ✨ feat(index.stories.tsx): extract common arguments into a constant and use it in Default and WithCustomTooltip stories
cannarocks
approved these changes
Sep 1, 2023
cannarocks
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.