Fix-transcript-obs-button #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ponent 🔨 refactor(highlight): remove handleSelection prop usage in index.stories and index file
🔧 fix(index.stories.tsx): remove unused imports and console logs 🔧 fix(index.tsx): remove unused imports and console logs, refactor Highlight function
🎨 style(highlight): add Italian text for storytelling in index.stories.tsx 🔥 refactor(highlight): remove unnecessary code from index.stories.tsx 🔨 refactor(index.stories.tsx): refactor words array into separate variable 🔨 refactor(index.stories.tsx): remove unused WithSelectionButton component 🔨 refactor(index.stories.tsx): remove onSelectionButtonClick and i18n props from WithTooltip.args 🚀 chore(index.stories.tsx): add WithSelectionButton story with default args 🔨 refactor(highlight/index.tsx): remove unused import statement 🎨 style(highlight/index.tsx): improve color styling and z-index for better UI visualisation
…mponent 🔧 refactor(highlight): pass start and end data attributes to ActiveWord component
marcbon
commented
Jun 11, 2024
| <ActiveWord> | ||
| <ActiveWord | ||
| data-start={props.start} | ||
| data-end={props.end} |
There was a problem hiding this comment.
Questo risolve un bug:
Se si selezionava a partire da una active word prendeva come start sempre 0 non avendo il data-start.
Valeva lo stesso anche per l'end.
…e unnecessary code 🔧 chore(index.stories.tsx): add WithSearch story with search functionality
iDome89
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 refactor(highlight): pass start and end data attributes to ActiveWord component