Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added features to nv_transform module #332

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

kushaljain-apra
Copy link
Collaborator

@kushaljain-apra kushaljain-apra commented Feb 13, 2024

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Description

Added rotation, source cropping and destination cropping features to the NvTransform Module. Implemented the serialization, get, set, and handle properties functions for the NvTransform Module. Added unit tests for scale, crop, scale & crop and scale & crop & rotate. Added documentation for each constructor and important functions as per the doxygen guidelines.

Alternative(s) considered

Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type

Type Choose one: (Feature)

Screenshots (if applicable)

Checklist

  • I have read the Contribution Guidelines
  • I have written Unit Tests
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach

Copy link
Collaborator

@joiskash joiskash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, please address the comments.

base/include/NvTransform.h Show resolved Hide resolved
base/include/NvTransform.h Outdated Show resolved Hide resolved
base/test/nvtransform_tests.cpp Outdated Show resolved Hide resolved
joiskash
joiskash previously approved these changes Jul 4, 2024
@joiskash joiskash enabled auto-merge (squash) July 4, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants