change default decimation parameter for python wrapper #285
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was stunned for a while when using Python wrapper, because the behavior was different from that of C.
Specifically, when the image is blurry and noisy (bad lighting & bad focus), and a tag is close enough so that it takes a good portion of an image, the Apriltag detection fails for Python wrapper, while the original C implementation manages to detect it nevertheless.
The problem was that the default decimation value was 2.0 for C, and 1.0 for Python wrapper.
As having different default behavior can be deceiving to many, and is counter-intuitive, I open this PR.