Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove old UNIX-specific Makefile #313

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

christian-rauch
Copy link
Collaborator

@christian-rauch christian-rauch commented Jan 24, 2024

I would like to remove the Makefile since:

  1. it is not tested on the CI
  2. does not compile the Python bindings
  3. confuses users how to build and install the apriltag library ("No rule to make target '../libapriltag.a' " when compiling demo codes #100)

Also see the discussion here: #210.

Copy link
Collaborator

@wxmerkt wxmerkt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am okay with this since it's out of sync with the CMake and leads to different behaviour. We may want to highlight explicitly in CHANGELOG and in the version bump that it's been removed in case some downstream workflow dependent on it without explicit version tagging (e.g. off master)

@christian-rauch christian-rauch force-pushed the rm_makefile branch 2 times, most recently from 533b5e2 to 8bb2178 Compare January 30, 2024 21:54
@christian-rauch christian-rauch merged commit 6a7b315 into AprilRobotics:master Jan 31, 2024
24 checks passed
@christian-rauch christian-rauch deleted the rm_makefile branch January 31, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants