Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tests #314

Merged
merged 5 commits into from
Feb 3, 2024
Merged

add tests #314

merged 5 commits into from
Feb 3, 2024

Conversation

christian-rauch
Copy link
Collaborator

@christian-rauch christian-rauch commented Jan 31, 2024

This adds tests on example images with a defined set of "ground truth" detections. I simply recorded the output of the detector once and compare to this in the tests. If the detections change in future, we can detect this with the tests.

There is some non-determinism in the order of the zarray_t of apriltag_detection returned by apriltag_detector_detect. I could resolve this across OSes, i.e. Linux, Windows and macOS will return the same order, but the order still differs across versions of the library for the same set of detections. Visually and by matching the outputs, one can see that they stayed the same. We may have to properly search between detected and true detections in the txt file to find mismatches.

ver 33369213973_9d9bb4cc96_c 34085369442_304b6bafd9_c 34139872896_defdb2f8d9_c
3.2 debug_output debug_output debug_output
3.3 debug_output debug_output debug_output
3.4 debug_output debug_output debug_output

@christian-rauch christian-rauch merged commit f8ce185 into AprilRobotics:master Feb 3, 2024
19 checks passed
@jrepp
Copy link
Contributor

jrepp commented Feb 9, 2024

really nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants