Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds tests on example images with a defined set of "ground truth" detections. I simply recorded the output of the detector once and compare to this in the tests. If the detections change in future, we can detect this with the tests.
There is some non-determinism in the order of the
zarray_t
ofapriltag_detection
returned byapriltag_detector_detect
. I could resolve this across OSes, i.e. Linux, Windows and macOS will return the same order, but the order still differs across versions of the library for the same set of detections. Visually and by matching the outputs, one can see that they stayed the same. We may have to properly search between detected and true detections in the txt file to find mismatches.