Upgrade to use web viewer 8.1 #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achenPDFTron
commented
Oct 6, 2021
| top: typeof style.top === 'number' ? style.top + pad : style.top, | ||
| left: typeof style.left === 'number' ? style.left + pad : style.left, | ||
| top: typeof style.top === 'number' ? (style.top as number) + pad : style.top, | ||
| left: typeof style.left === 'number' ? (style.left as number) + pad : style.left, |
There was a problem hiding this comment.
fixed this as typescript complained
achenPDFTron
commented
Oct 6, 2021
| "react": ">=16.8.0", | ||
| "react-dom": ">=16.8.0" | ||
| }, | ||
| "devDependencies": { | ||
| "@babel/core": "^7.7.4", | ||
| "@babel/preset-env": "7.9.0", |
There was a problem hiding this comment.
isntalled some of these to get the
npm start
npm run build
command to work
achenPDFTron
commented
Oct 6, 2021
| const fetchedBlob = await blob; | ||
| return await coreControls.createDocument(fetchedBlob, { extension, l: l || globalLicense.get() }); | ||
| try { | ||
| const document = await coreControls.createDocument(fetchedBlob, { extension, l: l || globalLicense.get() }); |
There was a problem hiding this comment.
this is the line throwing that uncaught exception:
File extension html is only supported by using WebViewer with WebViewer Server. See http://r.pdftron.com/fileformats for a full list of file formats supported by WebViewer. Visit https://www.pdftron.com/documentation/web/guides/wv-server-deployment for more information about WebViewer Server
changed the typing to be Core.Document | undefined to handle it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgraded to use WebViewer 8.1
Also caught and handled error from WebViewer createDocument API:
File extension html is only supported by using WebViewer with WebViewer Server. See http://r.pdftron.com/fileformats for a full list of file formats supported by WebViewer. Visit https://www.pdftron.com/documentation/web/guides/wv-server-deployment for more information about WebViewer Server