Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add _oldRev property in PatchDocumentsResponse. #270

Merged
merged 2 commits into from
Aug 14, 2020
Merged

Add _oldRev property in PatchDocumentsResponse. #270

merged 2 commits into from
Aug 14, 2020

Conversation

DiscoPYF
Copy link
Collaborator

fix #269

Quite close to #268 but that pull request was already up when I discovered that _oldRev was also missing.

@DiscoPYF DiscoPYF requested a review from a team July 11, 2020 20:48
@DiscoPYF DiscoPYF mentioned this pull request Jul 11, 2020
Merged
@DiscoPYF DiscoPYF force-pushed the addOldRevPatchMultiple branch from 90be916 to b8c8615 Compare July 18, 2020 17:43
@DiscoPYF
Copy link
Collaborator Author

Update:

  • Updated PatchDocumentsResponse model to follow other endpoints
  • Rebased on master

@DiscoPYF DiscoPYF requested a review from rossmills99 July 18, 2020 17:46
@DiscoPYF DiscoPYF merged commit 7f2cc30 into ArangoDB-Community:master Aug 14, 2020
@DiscoPYF DiscoPYF deleted the addOldRevPatchMultiple branch August 14, 2020 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rossmills99 rossmills99 rossmills99 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PatchDocumentsResponse does not expose _oldRev
2 participants
@DiscoPYF @rossmills99