Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use constants to represent index types. #376

Merged
merged 2 commits into from
May 16, 2022

Conversation

DiscoPYF
Copy link
Collaborator

@DiscoPYF DiscoPYF commented May 6, 2022

fix #375

@tjoubert @Zyqsempai @rossmills99 What do you think of this approach?

@DiscoPYF
Copy link
Collaborator Author

DiscoPYF commented May 6, 2022

Also if it can help a future soul, I spent hours wondering why IndexApiClientTestFixture.InitializeAsync was called more than once when doing right-click in IndexApiClientTest -> "Run Test(s)", creating test failures because the test collection was created multiple times. Turns out it's a known issue with Visual Studio and the workaround is to run all tests from the "Test Explorer".

xunit/xunit#2347

I'm using Microsoft Visual Studio Enterprise 2019 Version 16.11.10

@DiscoPYF
Copy link
Collaborator Author

I will push an update to resolve the conflicts.

@DiscoPYF DiscoPYF force-pushed the useConstantForIndexType branch from 54dd700 to 2cc2201 Compare May 14, 2022 11:37
@DiscoPYF
Copy link
Collaborator Author

Resolved conflicts.

@tjoubert tjoubert merged commit e613a42 into ArangoDB-Community:master May 16, 2022
@DiscoPYF DiscoPYF deleted the useConstantForIndexType branch May 16, 2022 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use string constants instead of enums to represent index types
2 participants