-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate methods and provide replacement for PutCursorAsync #396
Merged
tjoubert
merged 7 commits into
master
from
feature-3.8/DE-267-Deprecate-usage-of-deprecated-server-apis
Oct 26, 2022
Merged
Deprecate methods and provide replacement for PutCursorAsync #396
tjoubert
merged 7 commits into
master
from
feature-3.8/DE-267-Deprecate-usage-of-deprecated-server-apis
Oct 26, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ecated-server-apis
DiscoPYF
reviewed
Aug 28, 2022
DiscoPYF
changed the title
Deprecate methods
Deprecate methods and provide replacement for PutCursorAsync
Aug 29, 2022
…nc and amended test project.
DiscoPYF
approved these changes
Aug 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks @tjoubert
Approved. I left a minor comment that the null argument for bindVars
can now be removed for calls to PostCursorAsync
in tests, but not a blocker.
tjoubert
deleted the
feature-3.8/DE-267-Deprecate-usage-of-deprecated-server-apis
branch
October 26, 2022 05:04
tjoubert
restored the
feature-3.8/DE-267-Deprecate-usage-of-deprecated-server-apis
branch
October 31, 2022 19:08
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecated several properties and methods