Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate methods and provide replacement for PutCursorAsync #396

Merged

Conversation

tjoubert
Copy link
Contributor

Deprecated several properties and methods

@tjoubert tjoubert requested review from rossmills99 and DiscoPYF July 25, 2022 06:01
@tjoubert tjoubert added the enhancement New feature or request label Aug 2, 2022
@tjoubert tjoubert requested a review from DiscoPYF August 28, 2022 11:54
@DiscoPYF DiscoPYF changed the title Deprecate methods Deprecate methods and provide replacement for PutCursorAsync Aug 29, 2022
Copy link
Collaborator

@DiscoPYF DiscoPYF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks @tjoubert

Approved. I left a minor comment that the null argument for bindVars can now be removed for calls to PostCursorAsync in tests, but not a blocker.

@tjoubert tjoubert requested a review from mpoeter October 26, 2022 05:03
@tjoubert tjoubert merged commit ba458b7 into master Oct 26, 2022
@tjoubert tjoubert deleted the feature-3.8/DE-267-Deprecate-usage-of-deprecated-server-apis branch October 26, 2022 05:04
@tjoubert tjoubert restored the feature-3.8/DE-267-Deprecate-usage-of-deprecated-server-apis branch October 31, 2022 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants