Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make missing member handling configurable #399

Merged
merged 4 commits into from
Jul 27, 2022
Merged

Make missing member handling configurable #399

merged 4 commits into from
Jul 27, 2022

Conversation

tjoubert
Copy link
Contributor

Solves #213

  • Added ApiClientSerializationOptions.IgnoreMissingMember (true by default)
  • Set JsonSerializerSettings.MissingMemberHandling in JsonNetApiClientSerialization based on value in ApiClientSerializationOptions.IgnoreMissingMember

DiscoPYF
DiscoPYF approved these changes Jul 26, 2022
View reviewed changes
Copy link
Collaborator

@DiscoPYF DiscoPYF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, thanks for adding this enhancement 👍

I left some minor comments but they don't go in the way of merging, so I've approved.

arangodb-net-standard/Serialization/ApiClientSerializationOptions.cs Outdated Show resolved Hide resolved
arangodb-net-standard/Serialization/ApiClientSerialization.cs Outdated Show resolved Hide resolved
@tjoubert tjoubert merged commit a498627 into master Jul 27, 2022
@tjoubert tjoubert deleted the feature-3.8/DE-262-Make-MissingMemberHandler-configurable branch July 27, 2022 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DiscoPYF DiscoPYF DiscoPYF approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tjoubert @DiscoPYF