-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed dictionary item value serialization issue #401
Fixed dictionary item value serialization issue #401
Conversation
…CamelCasePropertyNamesExceptDictionaryContractResolver
…ter and CamelCasePropertyNamesExceptDictionaryContractResolver" This reverts commit ba917e7.
…CamelCasePropertyNamesExceptDictionaryContractResolver
@DiscoPYF , @rossmills99 , I have just fixed a test that apparently was expecting the property names of objects that are dictionary item values to remain the same (i.e. DontCamelCaseMe => "DontCamelCaseMe"). See 65705d1 |
@tjoubert Yes, I think it was by design. Basically we wanted the serializer to not touch object passed as bind variables to the Cursor or Transaction API. Your suggestion makes sense to me at a glance. 👍 It would also give more control to callers whenever they want to camelCase bind variables objects, e.g. when inserting a new document with the cursor API, which isn't possible at the moment unless they modify the serializer or use a |
I've added the option property and called it |
@DiscoPYF , can you take another look please? :-) |
Solved Issue #400
Amended the code to pass ApiClientSerializationOptions to DictionaryValueConverter