Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added cancellation token to async methods #406

Merged
merged 9 commits into from
Aug 8, 2022
Merged

Added cancellation token to async methods #406

merged 9 commits into from
Aug 8, 2022

Conversation

tjoubert
Copy link
Contributor

@tjoubert tjoubert commented Aug 1, 2022

Solves issue #204

  • Added cancellation token to interface and API class methods

@tjoubert tjoubert requested review from DiscoPYF and rossmills99 and removed request for DiscoPYF August 1, 2022 11:08
@tjoubert tjoubert linked an issue Aug 1, 2022 that may be closed by this pull request
Add cancellation support to all async methods #204
Closed
@tjoubert tjoubert added the enhancement New feature or request label Aug 2, 2022
DiscoPYF
DiscoPYF approved these changes Aug 5, 2022
View reviewed changes
Copy link
Collaborator

@DiscoPYF DiscoPYF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 👍

Will probably conflict with #403

@tjoubert tjoubert merged commit 3f0d6ea into master Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DiscoPYF DiscoPYF DiscoPYF approved these changes

@rossmills99 rossmills99 Awaiting requested review from rossmills99

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add cancellation support to all async methods
2 participants
@tjoubert @DiscoPYF