Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added header for driver version and other info #441

Merged

Conversation

tjoubert
Copy link
Contributor

See related issue for more information regarding requirements.
Added driver info header in HttpApiTransport.ApplyHeaders()

@tjoubert tjoubert added the enhancement New feature or request label Nov 21, 2022
@tjoubert tjoubert requested a review from DiscoPYF November 21, 2022 04:23
@tjoubert tjoubert self-assigned this Nov 21, 2022
@tjoubert tjoubert linked an issue Nov 21, 2022 that may be closed by this pull request
@tjoubert tjoubert requested a review from DiscoPYF November 30, 2022 08:03
@tjoubert
Copy link
Contributor Author

@DiscoPYF , this is done and ready. It'd be great if you can do a final check of approval before I merge.

Copy link
Collaborator

@DiscoPYF DiscoPYF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I left a minor comment about the casing of the constant. Will approve once discussed.

arangodb-net-standard/DriverConstants.cs Outdated Show resolved Hide resolved
@DiscoPYF DiscoPYF merged commit fd82aef into master Dec 9, 2022
@DiscoPYF DiscoPYF deleted the DE-428-440-header-for-driver-version-and-other-info branch December 9, 2022 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Header for driver version and other info
2 participants