Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed PostInvertedIndexAsync() response issue #454

Merged
merged 2 commits into from
Jan 23, 2023
Merged

Fixed PostInvertedIndexAsync() response issue #454

merged 2 commits into from
Jan 23, 2023

Conversation

tjoubert
Copy link
Contributor

@tjoubert tjoubert added bug Something isn't working breaking change Identify issues that contain a breaking change for existing consumer code labels Dec 21, 2022
@tjoubert tjoubert requested a review from DiscoPYF December 21, 2022 19:57
@tjoubert tjoubert self-assigned this Dec 21, 2022
@tjoubert tjoubert linked an issue Dec 21, 2022 that may be closed by this pull request
Deserialization exception on IndexApiClient.PostInvertedIndexAsync #443
Closed
DiscoPYF
DiscoPYF reviewed Dec 22, 2022
View reviewed changes
Copy link
Collaborator

@DiscoPYF DiscoPYF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. My only complain is that InvertedIndexResponse is a response class but inherits from PostInvertedIndexBody which is a request body. Consider creating an interface to hold the common properties.

arangodb-net-standard/IndexApi/Models/InvertedIndexResponse.cs Outdated Show resolved Hide resolved
arangodb-net-standard/AnalyzerApi/Models/AnalyzerFeatures.cs Outdated Show resolved Hide resolved
arangodb-net-standard/IndexApi/Models/InvertedIndexStoredValue.cs Outdated Show resolved Hide resolved
@tjoubert tjoubert requested a review from DiscoPYF December 22, 2022 18:50
@tjoubert tjoubert merged commit 085a41f into master Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DiscoPYF DiscoPYF Awaiting requested review from DiscoPYF

Assignees

@tjoubert tjoubert

Labels
breaking change Identify issues that contain a breaking change for existing consumer code bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deserialization exception on IndexApiClient.PostInvertedIndexAsync
2 participants
@tjoubert @DiscoPYF