Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing properties to Post, Put and Patch document query objects #460

Merged
merged 4 commits into from
Jan 18, 2023
Merged

Add missing properties to Post, Put and Patch document query objects #460

merged 4 commits into from
Jan 18, 2023

Conversation

tjoubert
Copy link
Contributor

@tjoubert tjoubert commented Jan 16, 2023 •
edited
Loading

@tjoubert tjoubert added the enhancement New feature or request label Jan 16, 2023
@tjoubert tjoubert requested a review from DiscoPYF January 16, 2023 10:36
@tjoubert tjoubert self-assigned this Jan 16, 2023
DiscoPYF
DiscoPYF reviewed Jan 18, 2023
View reviewed changes
Copy link
Collaborator

@DiscoPYF DiscoPYF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat 👍

Will approve, but I noticed one thing:

According to the documentation https://www.arangodb.com/docs/stable/http/document-working-with-documents.html

Query parameter refillIndexCaches should also be available in the following classes:

  • DeleteDocumentQuery
  • DeleteDocumentsQuery
  • PatchDocumentQuery
  • PutDocumentsQuery

Maybe update them here while you're at it?

@DiscoPYF
Copy link
Collaborator

Apparently refillIndexCache was added in ArangoDB 3.9, so i've added the related tag for reference.

@DiscoPYF DiscoPYF added the ArangoDB 3.9 Identify issues for supporting ArangoDB 3.9 label Jan 18, 2023
@tjoubert
Copy link
Contributor Author

Thanks.

@tjoubert tjoubert requested a review from DiscoPYF January 18, 2023 07:38
@DiscoPYF DiscoPYF merged commit 93ee23d into master Jan 18, 2023
@DiscoPYF DiscoPYF deleted the DE-257-add-overwriteMode-on-post-documents branch January 18, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DiscoPYF DiscoPYF DiscoPYF approved these changes

Assignees

@tjoubert tjoubert

Labels
ArangoDB 3.9 Identify issues for supporting ArangoDB 3.9 ArangoDB 3.10 enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for overwriteMode introduced in 3.7
2 participants
@tjoubert @DiscoPYF