Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: return value of CREATE PROPERTY for DEFAULT attribute #1831

Merged
merged 1 commit into from
Nov 20, 2024
Merged

fix: return value of CREATE PROPERTY for DEFAULT attribute #1831

merged 1 commit into from
Nov 20, 2024

Conversation

gramian
Copy link
Collaborator

@gramian gramian commented Nov 20, 2024

What does this PR do?

CREATE PROPERTY is returning the evaluated attribute value for attribute type default, this is not only inconsistent with the attribute value set but also confusing as it appears to a user as if the attribute was evaluated.

Motivation

Fixing ALTER PROPERTY.

Related issues

#1802

Checklist

  • I have run the build using mvn clean package command
  • My unit tests cover both failure and success scenarios

@lvca lvca added this to the 24.11.2 milestone Nov 20, 2024
@lvca lvca self-requested a review November 20, 2024 14:20
lvca
lvca approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@lvca lvca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes sense, thanks!

@mergify mergify bot merged commit f44ecba into ArcadeData:main Nov 20, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lvca lvca lvca approved these changes

Assignees

@gramian gramian

Labels
None yet
Projects
None yet
Milestone
24.11.2
Development

Successfully merging this pull request may close these issues.
2 participants
@gramian @lvca