Core: store multidata/multisave enums by value on py3.11 #1783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is what py3.10 did and should be better for AP than the new default
Berserker66
approved these changes
May 2, 2023
kindasneaki
pushed a commit
to kindasneaki/Archipelago
that referenced
this pull request
Jun 28, 2023
…MW#1783) This is what py3.10 did and should be better for AP than the new default
FlySniper
pushed a commit
to FlySniper/Archipelago
that referenced
this pull request
Nov 14, 2023
…MW#1783) This is what py3.10 did and should be better for AP than the new default
Jouramie
pushed a commit
to Jouramie/Archipelago
that referenced
this pull request
Feb 28, 2024
…MW#1783) This is what py3.10 did and should be better for AP than the new default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Python 3.11 changed to pickle/store enums by name rather than by value. This breaks our safe unpickle, it produces bigger pickles and it makes it impossible to rename keys in enums after the fact.
Changing it back to ByValue produces the same output as py<=3.10.
Change in python is here: python/cpython#26658
How was this tested?